r/equinix_metal_virtual_circuit vlan_id field must be updateable, and not force_new

[ocobles]

Looking for an alternative for the situation described in #222

I just found that vlan_id has force_new but it is something that can be updated in the API.

terraform-provider-equinix/equinix/resource_metal_virtual_circuit.go

Lines 74 to 80 in eae28ce

	"vlan_id": {
	Type: schema.TypeString,
	Optional: true,
	Description: "UUID of the VLAN to associate",
	ExactlyOneOf: []string{"vlan_id", "vrf_id"},
	ForceNew: true,
	},

It must be replaced with:

"vlan_id": { 
 	Type:         schema.TypeString, 
 	Optional:     true, 
 	Description:  "UUID of the VLAN to associate", 
 	ExactlyOneOf: []string{"vlan_id", "vrf_id"}, 
 },

I think there was a confusion between vlan_id and vnid, because they are also mixed in the API, actually vnid is been checked in the update function but it is a computed attribute.

terraform-provider-equinix/equinix/resource_metal_virtual_circuit.go

Lines 293 to 296 in eae28ce

	if d.HasChange("vnid") {
	vnid := d.Get("vnid").(string)
	ur.VirtualNetworkID = &vnid
	}

It must be replaced with:

if d.HasChange("vlan_id") { 
 	vnid := d.Get("vlan_id").(string) 
 	ur.VirtualNetworkID = &vnid 
 }