[Bug]: equinix_fabric_routing_protocol not using schema timeouts

[ocobles]

equinix_fabric_routing_protocol waitUntilRoutingProtocolIsProvisioned function is not taking default schema timeout

terraform-provider-equinix/equinix/resource_fabric_routing_protocol.go

Line 573 in 42737f8

Timeout: 5 * time.Minute,

In fact none of the "WaitFor" functions do it. I have also been able to verify that the same thing happens with other Fabric resources such as fabric_connection, fabric_cloud_router, fabric_network... This means that if users define a value to override the default value it is never being used.

Here's an example of how the schema timeouts must be consumed

terraform-provider-equinix/equinix/resource_metal_device.go

Line 562 in 42737f8

createTimeout := d.Timeout(schema.TimeoutCreate) - 30*time.Second - time.Since(start)

[ocobles]

Furthermore, it almost always gives an error, so a longer default timeout would be more appropriate.

[thogarty]

This has been updated and is available after this PR was merged: #631

Closing issue.