feat: officially deprecate the metal_device_network_type resource #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctreatma
commented
Sep 10, 2024
ctreatma
force-pushed
the
deprecate-metal-network-type
branch
from
30da0de to
a666c49
Compare
ctreatma
force-pushed
the
deprecate-metal-network-type
branch
from
a666c49 to
c343b92
Compare
ctreatma
commented
Sep 11, 2024
| @@ -2,7 +2,10 @@ | |||
| subcategory: "Metal" | |||
| --- | |||
|
|
|||
| # equinix_metal_device_network_type (Resource) | |||
| # equinix_metal_device_network_type (Resource, Deprecated) | |||
There was a problem hiding this comment.
There doesn't seem to be a standard for marking entire resources as deprecated in the docs. The HashiCorp recommendations are focused only on the code.
There was a problem hiding this comment.
Actually the differentiation between resource / datasource in parentheses seems to be a thing of the past, I don't see it in the documentation of any other provider. For me it's fine like this, but the documentation generation plugin won't put things like that either if we stop using templates in the future.
There was a problem hiding this comment.
So the Note below might be enough, but again, I think the way you put it seems clarifying
ctreatma
force-pushed
the
deprecate-metal-network-type
branch
from
c343b92 to
a6cc80a
Compare
ctreatma
force-pushed
the
deprecate-metal-network-type
branch
from
a6cc80a to
7cb3405
Compare
ctreatma
force-pushed
the
deprecate-metal-network-type
branch
from
7cb3405 to
ea43726
Compare
ocobles
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.