feat: Add BGP Metrics fields for fabric cloud router routing protocols #794
Conversation
| @@ -712,6 +748,16 @@ func routingProtocolBgpIpv4TerraformToGo(routingProtocolBgpIpv4Request []interfa | |||
| enabled := bgpIpv4Map["enabled"].(bool) | |||
| rpBgpIpv4.SetEnabled(enabled) | |||
|
|
|||
| if outboundAsPrependCount := bgpIpv4Map["outbound_as_prepend_count"].(int); outboundAsPrependCount > 0 { | |||
There was a problem hiding this comment.
I realized that 0 won't be included then. Is there a different reason for outboundAsPrependCount > 0 ?
There was a problem hiding this comment.
Ah, good find on the wiki. This creates a problem though. SDKv2 always assigns the zero value of the type and doesn't have the concept of null for an unassigned value. Zero value for int is always 0, and I wasn't trying to avoid sending the value in the API request if the user didn't explicitly include it in the config.
Might have to rework how we can handle this case in SDKv2; or we don't support this feature until we can move to terraform-plugin-framework.
There was a problem hiding this comment.
I have a plan that can work though. We can use strings for these values and convert internally during mapping.
There was a problem hiding this comment.
That could work.
In that case, if it's a string "0" (in SDKv2) it would mean an actual value of outboundAsPrependCount and if it is int 0, then it would mean 0 (for unassigned value/null).
There was a problem hiding this comment.
Let me rethink this.
You said we can use strings and convert during mapping, but then what about int 0 values (unassigned values)
There was a problem hiding this comment.
Never mind, I understood how you can implement this in the code.
|
@d-bhola , updated it to string type to account for user possibly not adding the parameter and to account for allowing the user to choose zero explicitly. New test run after changes: |
|
This PR is included in version 2.7.0 🎉 |
#794) * Added additional optional fields to routing protocols bgp_ipv4 and bgp_ipv6 objects * Included acceptance testing Acceptance Tests for Fabric will be failing intermittently because in UAT the Vlan Tags are not being released quickly (or possibly at all). I've included evidence of local passing tests in a screenshot below: <img width="1227" alt="image" src="https://github.com/user-attachments/assets/74c340b8-7957-4dcf-88d2-ba2cdd8147b2">
Acceptance Tests for Fabric will be failing intermittently because in UAT the Vlan Tags are not being released quickly (or possibly at all). I've included evidence of local passing tests in a screenshot below: