Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Tooltip on disabled elements for Safari #1204

Closed
pomfrida opened this issue Apr 8, 2021 · 2 comments
Closed

Improve Tooltip on disabled elements for Safari #1204

pomfrida opened this issue Apr 8, 2021 · 2 comments
Labels

Comments

@pomfrida
Copy link
Contributor

pomfrida commented Apr 8, 2021

Currently users have to wrap the disabled element with a span (or inline-block element), and add style={{ pointerEvents: none }} to the disabled button

Should try to implement this logic to tooltip so the users won't have to do this

@mimarz mimarz added the core-react eds-core-react label Apr 8, 2021
@vnys vnys added the hacktoberfestivus Issues ready for Hacktober label Oct 11, 2021
@akvam akvam removed the hacktoberfestivus Issues ready for Hacktober label Feb 16, 2022
@oddvernes
Copy link
Collaborator

The problem is safari fires mouseenter on disabled elements, but not mouseleave, so the tooltip is stuck visible (pressing escape to close it still works). This has been an issue in react since 2015
I see reachUi have made their own workaround using mousemove, but I don't know if this could be easily implemented in our own solution.

@oddvernes
Copy link
Collaborator

Closing as it is both a bug in safari, and floating-ui disallows tooltip on disabled buttons entirely now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants