Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

Make RecordType enum names more general #198

Open
xjules opened this issue Jan 25, 2022 · 1 comment
Open

Make RecordType enum names more general #198

xjules opened this issue Jan 25, 2022 · 1 comment

Comments

@xjules
Copy link
Contributor

xjules commented Jan 25, 2022

Is your feature request related to a problem? Please describe.
RecordType is set very specifically, ie.:

class RecordType(Enum):
    f64_matrix = 1
    file = 2

and since the type is to be exploited more (in ert3) in the near future we might consider rename it for instance:

class RecordType(Enum):
    numerical = 1
    blob = 2
@pinkwah
Copy link
Collaborator

pinkwah commented Jan 31, 2022

Make sure to allow all types:

https://github.com/equinor/ert/blob/a0e3887f89cbe06d15358c840cb9d35677aaaa2e/ert/data/record/_record.py#L55-L64

class RecordType(Enum):
    MAPPING_INT_FLOAT = 1  # List[float] and Mapping[int, float] are identical mappings
    MAPPING_STR_FLOAT = 2

    BYTES = 3

    NUMERICAL_TREE = 4
    BLOB_TREE = 5

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants