Removed outer scrollbar in questionnaire #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiaht
approved these changes
Jan 4, 2022
To avoid the outer scrollbar, the inner div is set to a height that needs to be precisely the height of the view. This is calculated by fetching the heights and margins of some of the view elements, but for some reason the scroll bar got smaller, but didn't disappear. In this PR I simply added one pixel to the height, which made it finally disappear.
denektenina
force-pushed
the
outer-scrollbar
branch
from
b3a4b3b
to
ab3791d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid the outer scrollbar, the inner div is set to a height that needs to be precisely the height of the view. This is calculated by fetching the heights and margins of some of the view elements, but for some reason the scroll bar got smaller, but didn't disappear. In this PR I simply added one pixel to the height, which made it finally disappear.
Before:
After:
Could be smart to pull this down to test, in case it only works on my machine.