Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MediaConfig causes circular dependency #663

Closed
Eddasol opened this issue Dec 4, 2024 · 0 comments · Fixed by #667
Closed

MediaConfig causes circular dependency #663

Eddasol opened this issue Dec 4, 2024 · 0 comments · Fixed by #667
Assignees
@Eddasol
Labels
bug Something isn't working

Comments

@Eddasol
Copy link
Contributor

Eddasol commented Dec 4, 2024 •
edited
Loading

Describe the bug
MediaConfig is used in robotInterface but placed in isar which causes circular dependency when used by the robot packages. Definition of MediaConfig needs to be placed in robot interface instead

To Reproduce
Steps to reproduce the behavior:

Expected behavior

Screenshots
@Eddasol Eddasol added the bug Something isn't working label Dec 4, 2024
@sondreo sondreo self-assigned this Dec 6, 2024
@Eddasol Eddasol assigned Eddasol and unassigned sondreo Dec 6, 2024
@Eddasol Eddasol linked a pull request Dec 6, 2024 that will close this issue
Move MediaConfig to prevent circular dependencies #667
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Eddasol Eddasol

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move MediaConfig to prevent circular dependencies Eddasol/isar
2 participants
@Eddasol @sondreo