-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make c/c++ interface private #954
Comments
This was referenced Aug 6, 2024
Merged
Merged
This was referenced Aug 13, 2024
Merged
This was referenced Aug 21, 2024
This was referenced Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We will make the
c
/c++
interface of resdata (formerly known as ecl/libecl) private.The rationale is that there are a lot of functionality that is only exposed in c/c++ which is in little use, and we would like to clean this up in order to have a library that is easier to maintain. ert used to be a big consumer of this interface, but this is not the case anymore. Other users
The next step is ta create a new major version bump of Resdata with the
c
/c++
interface as private. This means all comments in README and documentation about the c/c++ interface will disappear. Also the following lines will be removed:resdata/python/resdata/__init__.py
Line 69 in c62737a
resdata/setup.py
Line 86 in c62737a
Note: The binaries exposed by resdata is still considered public:
resdata/setup.py
Lines 37 to 53 in c62737a
The text was updated successfully, but these errors were encountered: