Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmuobs - Non-unique observation labels when converting from resinsight to ERT obs format #635

Closed
asnyv opened this issue Dec 6, 2023 · 0 comments · Fixed by #636
Closed
Labels
bug Something isn't working

Comments

@asnyv
Copy link
Contributor

asnyv commented Dec 6, 2023

The ResInsight format does not have labels, and a label is made based on the key (vector name). This is not unique if multiple observations are present for the same key (vector), and ERT doesn't like that.

dframe["LABEL"] = dframe["KEY"].astype(str) # + "-" + dframe["DATE"].astype(str)

There is a commented part of the line which adds the date, which is an option. Another alternative is to add an index like what is done for the yaml based format:

rowdict["LABEL"] = keylist["key"] + "-" + str(obs_idx + 1)

An index is maybe the best to be consistent with the behavior of the yaml based.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant