Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout of Webviz #144

Open
HansKallekleiv opened this issue Jun 8, 2021 · 1 comment
Open

Layout of Webviz #144

HansKallekleiv opened this issue Jun 8, 2021 · 1 comment
Labels

Comments

@HansKallekleiv
Copy link
Collaborator

HansKallekleiv commented Jun 8, 2021

Currently Webviz plugins, e.g. https://github.com/equinor/webviz-subsurface are designed individually with no clear guidelines with regards to layout and styling. By providing a library of layout components we can greatly reduce the amount of code needed and easier ensure consistent look and behaviour across different plugins.

We should discuss which components to be added.

Additionally the main webviz layout should be made more flexible.

List of potential layout components

App component

Component that contains the full webviz app, replacing the current sidebar + main view layout in webviz-config.

  • Contains global settings, such as
    • Theme
    • Global filters
    • ...

Page component

A component that contains the plugin content.

  • Has a grid system for arranging child components
  • Has the current WebvizPluginPlaceHolder toolbar
  • Allows rearranging of children components using drag and drop

Content frame

A component that wraps any other content, such as a plotly figure or a table.
Toolbar with buttons for:

  • Fullscreen toggle
  • Description

Selector component

Component that wraps a selector, such as a dropdown or Select

  • Has a label
  • Can be minimized

Various examples from webviz-subsurface used to make selections:
image

Plotly figure wrapper

Contains the plotly figure

@rubenthoms
Copy link
Collaborator

rubenthoms commented Jul 13, 2022

@HansKallekleiv can you evaluate if the issues/improvements you mentioned are fixed/covered by WLF (#219)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants