Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add concurrency on actions ran on PRs #857

Open
inFocus7 opened this issue Sep 5, 2023 · 0 comments
Open

CI: Add concurrency on actions ran on PRs #857

inFocus7 opened this issue Sep 5, 2023 · 0 comments
Labels
CI This issue is related to CI-related tasks

Comments

@inFocus7
Copy link
Contributor

inFocus7 commented Sep 5, 2023

Describe the solution you'd like

I notice that none of our actions/jobs have concurrency set. This means it is possible that a pull request can have multiple running actions from older commits running at the same time, costing resources.

For example:

  1. I push a commit, causing our various tests to run.
  2. I push another commit while above is running, causing another set of tests to run.
  3. Since we don't have any job concurrency set up, the older set of tests/actions continue running while new ones are as well.

Setting up concurrency allows us to either queue the latest commit runs, or simply cancel the previously-running actions.

There are fail-safes where maintainers have to approve runs (I believe for first-time contributors), but still worth having this for users who don't need approvals to run CI on commit.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Eraser version:
  • Kubernetes version: (use kubectl version):
@inFocus7 inFocus7 added the enhancement New feature or request label Sep 5, 2023
@salaxander salaxander added CI This issue is related to CI-related tasks and removed enhancement New feature or request labels Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI This issue is related to CI-related tasks
Projects
None yet
Development

No branches or pull requests

2 participants