Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C# port does not support new toll-free numbers. Out of sync with current library. #9

Open
ghost opened this issue Aug 7, 2014 · 7 comments

Comments

@ghost
Copy link

ghost commented Aug 7, 2014

We noticed that the current libphonenumber-csharp settings do not support 844 toll free numbers in the US. When we investigated further we noticed that there have been many updates to the current library that would be beneficial to bring into your c# port.

If you would like I would like to help with getting these changes into your library.

Let me know if you plan on updating this library soon and perhaps I can help with that.

Thanks.

@ghost ghost changed the title C# port does not support new toll-free numbers. Has fallen out of sync. C# port does not support new toll-free numbers. Out of sync with current library. Aug 7, 2014
@erezak
Copy link
Owner

erezak commented Aug 9, 2014

Thank you for bringing this up.

This is indeed the issue. I am trying to keep up with it, but it will have to wait a bit.
If you have any pull requests, I can probably squeeze it in even earlier.

Thank you.

@ghost
Copy link
Author

ghost commented Aug 11, 2014

We ended up having some migration issues with our project when we created our own nuget package.
Not sure if it is because we are running .Net Framework 4.

We ended up having to go with the following repo to start with:
https://bitbucket.org/pmezard/libphonenumber-csharp/wiki/Home

I currently have a fork with only updates to the xml files. The code would also need to be updated to be safe.

If you would like to work together on getting this project updated I am willing to help.

@vaerge
Copy link

vaerge commented Aug 15, 2014

Just so I understand; does this mean that the reason I have problems with Ecuador mobile right now could be because of the C# port being out of sync with the libphonenumber library?
(I just opened an issue on the original project regarding this destination, so I'm trying to find out if the real issue is really that I'm using a C# port that is out of sync)
Thanks!

@rabastado
Copy link

hello,

Thank you for your work.

We are using quite a few 844 numbers. It is an issue for the business that we cannot support those. Do you have an ETA for when those will be included? We moved to a different provider of toll free numbers because the current library does not support those, at the same time, we still have a few customers with the old 844 numbers that we need to support.

Thank you,
Rinat

@rabastado
Copy link

Hello. We need to support the 844 numbers. We are getting a lot of pressure from our marketing team. Could you let us know if you are planing to add this support?

Thank you,
Rinat

@erezak
Copy link
Owner

erezak commented Oct 7, 2015

I'm working on a rewrite of the port, as I want to have an easier way of merging data changes.

@duaneking
Copy link

Any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants