Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught TypeError JsonSchema Factory / drop <=0.2 #57

Closed
ScreamingDev opened this issue Mar 15, 2018 · 4 comments
Closed

Uncaught TypeError JsonSchema Factory / drop <=0.2 #57

ScreamingDev opened this issue Mar 15, 2018 · 4 comments
Assignees
Labels

Comments

@ScreamingDev
Copy link

Steps required to reproduce the problem

  1. Go PHP 7.0
  2. composer require --dev localheinz/composer-normalize
  3. composer

Expected Result

  • Usual composer listing

Actual Result

  • Version 0.2.0 installed
  • BADABUM

Fatal error: Uncaught TypeError: Argument 1 passed to JsonSchema\Constraints\Factory::__construct() must be an instance of JsonSchema\Uri\UriRetriever, instance of JsonSchema\SchemaStorage given,

Please drop this version from packagist.org or fix this.

@localheinz localheinz self-assigned this Mar 15, 2018
@localheinz localheinz added the bug label Mar 15, 2018
@localheinz
Copy link
Member

Thank you for reporting, @ScreamingDev!

Will take a look later.

@localheinz
Copy link
Member

I dropped support for PHP 7.0 in #30 because field names that are empty strings are not properly decoded in PHP 7.0. Not sure what the best practice is, should I actually delete older versions from Packagist?

@ScreamingDev
Copy link
Author

Dunno. I would follow some strategy like:

Last one is valid for your 0.2.0 because it doesn even work with 7.0 anymore.

@stale
Copy link

stale bot commented Jul 8, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 8, 2018
@stale stale bot closed this as completed Jul 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants