Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use react-tools 0.12.0 #39

Closed
zbyte64 opened this issue Oct 28, 2014 · 3 comments
Closed

Update to use react-tools 0.12.0 #39

zbyte64 opened this issue Oct 28, 2014 · 3 comments

Comments

@zbyte64
Copy link

zbyte64 commented Oct 28, 2014

Currently the tool uses 0.11 regardless if you have 0.12 installed

@ericclemmons
Copy link
Owner

A couple of options:

  1. Update the dependencies in package.json? That'd be easiest.
  2. Allow your Gruntfile.js to pass in a reference to react-tools in this task.

Because this is where it's referenced:

https://github.com/ericclemmons/grunt-react/blob/master/tasks/react.js#L13

There's not really an easy way for my package to reference your package, is there?

Option 1 seems to be best...

@jackwanders
Copy link
Collaborator

Unfortunately, Option 1 won't be sufficient, as there are a few breaking changes, at least as far as your tests are concerned. Two breaking changes I saw right away:

  • .js files will get transformed if run through react. This is most likely due to the dropped requirement of the /** @jsx React.DOM **/ annotation
  • <p>Hello</p> no longer gets compiled to React.DOM.p(null, "Hello"), but rather React.createElement("p", null, "Hello")

I've created pull request #40 to update the react-tools dependency. I include a version change from 0.9.0 to 0.10.0 because of the breaking changes introduced in react tools v0.12.0

@ericclemmons
Copy link
Owner

Closing in favor of #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants