-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JOSS Review] - tests failing #38
Comments
Thank you for raising this! This was due to a CPython This is now fixed in #42, and the GitHub actions have been updated to run the tests with multiple Python versions. Related to openjournals/joss-reviews#6537. |
Great, thank you, closing this issue. |
Dear authors,
I ran the tests in the repository using pytest and it looks like there is an issue with a test failing. Perhaps a good idea to add automated testing using Github CI / Github Actions? I have pasted in the output below:
(base) ➜ rfbzero git:(main) pytest tests/
============================= test session starts ==============================
platform darwin -- Python 3.11.8, pytest-7.4.0, pluggy-1.0.0
rootdir: /Users/johh/github/rfbzero
configfile: pyproject.toml
plugins: anyio-4.2.0
collected 73 items
tests/test_crossover.py .. [ 2%]
tests/test_degradation.py ......................... [ 36%]
tests/test_experiment.py .......F.......... [ 61%]
tests/test_redox_flow_cell.py ............................ [100%]
=================================== FAILURES ===================================
___________________________ TestLowCapacity.test_cc ____________________________
self = <tests.test_experiment.TestLowCapacity object at 0x117c58cd0>
capsys = <_pytest.capture.CaptureFixture object at 0x117ccced0>
E AssertionError: assert 'CyclingStatus.LOW_CAPACITY.' == 'capacity is ...CLS capacity.'
E - capacity is less than 1% of initial CLS capacity.
E + CyclingStatus.LOW_CAPACITY.
tests/test_experiment.py:536: AssertionError
=========================== short test summary info ============================
FAILED tests/test_experiment.py::TestLowCapacity::test_cc - AssertionError: assert 'CyclingStatus.LOW_CAPACITY.' == 'capacity is ...CLS...
======================== 1 failed, 72 passed in 27.35s =========================
The text was updated successfully, but these errors were encountered: