Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's have the removable token not be a <button> #10

Closed
Reasonable-Solutions opened this issue Apr 15, 2016 · 2 comments
Closed

Let's have the removable token not be a <button> #10

Reasonable-Solutions opened this issue Apr 15, 2016 · 2 comments
Labels

Comments

@Reasonable-Solutions
Copy link

In firefox buttons capture all events so children cannot be interactive, this is according to spec.
The official examples http://ericgio.github.io/react-bootstrap-typeahead/ are also broken in Firefox.
I propose that instead of rendering a button we render a div aria role button, etc.
PR incoming.

@ericgio
Copy link
Owner

ericgio commented Apr 16, 2016

Thanks for the report and the PR.

@ericgio
Copy link
Owner

ericgio commented Apr 20, 2016

Fixed in v0.3.2

@ericgio ericgio closed this as completed Apr 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants