Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE 11 Issues with AsyncTypeahead #189

Closed
justinhp opened this issue May 22, 2017 · 5 comments
Closed

IE 11 Issues with AsyncTypeahead #189

justinhp opened this issue May 22, 2017 · 5 comments

Comments

@justinhp
Copy link

justinhp commented May 22, 2017

Unfortunately we still need to support IE 11 and it was found by our QA team that there was an issue in IE 11. It occurs when typing quickly into the Async Typeahead. It starts dropping characters in the input.

Version

v1.3.0

Steps to reproduce

  1. In IE 11, go to https://ericgio.github.io/react-bootstrap-typeahead/
  2. Quickly start typing any sentence into the AsyncTypeahead example
  3. It starts dropping characters

Expected Behavior

Input is what you typed

Actual Behavior

Drops characters when typing fast

thanks!
Justin

@MHultman
Copy link

I would like to have this fixed as well!

This is not only in IE11. I've also experience it in Chrome.
I'm not able to reproduce this in the demo environment, but in our dev-project.

The problem appears when you add a delay for search.

  1. you write.
  2. 200ms goes by since last input.
  3. Request goes to server.
  4. You write something more before response returns.
  5. Response arrive

The result is that the characters written in step 4 are removed.

@MHultman
Copy link

I've been searching for this bug for two days now ..
Appears only in IE 11.
When you change the options state in the <AsyncTypeahead ... options={this.state.options}.. /> this will trigger some rendering. If you write in the input during the render, the text state will be set to the search query text. The "effect" is that your last input is removed. Same goes when using backspace.

Hopefully someone else can have a look at it?

@justinhp
Copy link
Author

justinhp commented Jun 28, 2017

@MHultman Thanks for looking into this. This seems to be an issue with React itself, however I believe it was fixed in the latest release, 15.6.x but haven't verified it. You can see a discussion of the issue here
https://github.com/facebook/react/issues/7027.

I ended up using react-autosuggest and implemented one of the solutions discussed here: moroshko/react-autosuggest#261 and an additional discussion can be found here moroshko/react-autosuggest#350. The same solution could probably be applied to this lib as well.

@ericgio ericgio added this to the v2.0.0 milestone Jul 26, 2017
@bbarnell
Copy link

@MHultman @justinhp @ericgio @hyzhak @kav Yep. It's fixed in React version 15.6.1

@ericgio
Copy link
Owner

ericgio commented Jul 28, 2017

I'm unable to repro this issue on IE11 using React 15.6.1. I'll consider the issue closed unless someone reopens with more specific repro steps or a repro case. Thanks.

@ericgio ericgio closed this as completed Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants