Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert library from Flow to TypeScript #619

Closed
caiquecastro opened this issue Feb 13, 2021 · 6 comments
Closed

Convert library from Flow to TypeScript #619

caiquecastro opened this issue Feb 13, 2021 · 6 comments

Comments

@caiquecastro
Copy link

Is your feature request related to a problem? Please describe.
I'm having issues to integrate this library with Typescript. But I could send a PR if the library is interested.

Describe the solution you'd like
Replace flow by typescript

How is this solution useful to others?
Flow popularity and usage has been dropping. Typescript is more common.

Describe alternatives you've considered
N/A

Additional context
N/A

@ericgio
Copy link
Owner

ericgio commented Feb 13, 2021

Hi @caiquecastro, thanks for the feature request. I don't have plans to convert the library to TS for now. In the meantime, however, you can use the types provided by DefinitelyTyped.

@ericgio ericgio changed the title Interest in Typescript better support Convert from library Flow to TypeScript Feb 13, 2021
@ericgio ericgio changed the title Convert from library Flow to TypeScript Convert library from Flow to TypeScript Feb 13, 2021
@caiquecastro
Copy link
Author

Hi @ericgio. Thanks for the reply. Yeah.. I'm using the types from DefinitelyTyped for now!

@nycynik
Copy link

nycynik commented Jun 27, 2021

Does that help with the issues around Label? I've been trying to solve this and found several SO questions w/o answers to this.
Like this one. It works fine but shows errors.

index.d.ts(204, 5): The expected type comes from property 'labelKey' which is declared here on type 'IntrinsicAttributes & IntrinsicClassAttributes<AsyncTypeahead> & Readonly<AsyncTypeaheadProps> & Readonly<...>'

index.d.ts(242, 5): The expected type comes from property 'options' which is declared here on type 'IntrinsicAttributes & IntrinsicClassAttributes<AsyncTypeahead> & Readonly<AsyncTypeaheadProps> & Readonly<...>'

@ericgio
Copy link
Owner

ericgio commented Jun 28, 2021

@nycynik: If you believe there are problems with the types, please start a discussion over in the DefinitelyTyped repo.

@nycynik
Copy link

nycynik commented Jun 29, 2021

Thanks, will do.

@ericgio
Copy link
Owner

ericgio commented Oct 11, 2021

As of v6.0.0-alpha.1, the library has been re-written in Typescript.

@ericgio ericgio closed this as completed Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants