Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse parenthesized conditional expressions #34

Closed
ErichDonGubler opened this issue Oct 27, 2023 · 0 comments · Fixed by #35
Closed

Parse parenthesized conditional expressions #34

ErichDonGubler opened this issue Oct 27, 2023 · 0 comments · Fixed by #35
Assignees
@ErichDonGubler
Labels
A-parsing-metadata A-webgpu-cts bug Something isn't working

Comments

@ErichDonGubler
Copy link
Collaborator

Currently, conditional property values like if (os == "win") and debug don't parse, because we don't parse conditionals correctly. This seems simple to fix, but I haven't discovered the right incantation of chumsky to use with the pratt parser we're using here: https://github.com/ErichDonGubler/whippit/blob/44e58a051052e12874b171297e033c4729f810a1/src/metadata/properties/conditional/expr.rs#L79-L87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ErichDonGubler ErichDonGubler

Labels
A-parsing-metadata A-webgpu-cts bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Accept parentheses in conditional expressions in metadata erichdongubler-mozilla/moz-webgpu-cts
1 participant
@ErichDonGubler