Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

different implementation from the original paper #8

Open
vanpersie32 opened this issue Mar 18, 2018 · 0 comments
Open

different implementation from the original paper #8

vanpersie32 opened this issue Mar 18, 2018 · 0 comments

Comments

@vanpersie32
Copy link

Hey, I think the implementation is different from the original paper. According to the paper, the output attention is computed using the output of LSTM at current time step and the attributes. But your implementation here is computed using the output of LSTM at previous time step and the attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant