Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename basic_istream_view to istream_view #632

Open
cjdb opened this issue Aug 4, 2019 · 0 comments
Open

Rename basic_istream_view to istream_view #632

cjdb opened this issue Aug 4, 2019 · 0 comments

Comments

@cjdb
Copy link
Contributor

cjdb commented Aug 4, 2019

I was under the mistaken impression that istream_iterator didn't support non-std::istream types based on its name, and so I named basic_istream_iterator as a "fix". Now that I know better, I think it should be renamed to istream_view, and we move the factory into namespace views as istream.

P1035R7 (and C++20 CD)

auto example1 = std::ranges::basic_istream_view<int>{std::cin};
auto example2 = std::ranges::istream_view<int>(std::cin);

Proposed

auto example1 = std::ranges::istream_view<int>{std::cin};
auto example2 = std::views::istream<int>(std::cin);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant