Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collaboration #519

Closed
nworbnhoj opened this issue Apr 16, 2016 · 2 comments
Closed

Collaboration #519

nworbnhoj opened this issue Apr 16, 2016 · 2 comments

Comments

@nworbnhoj
Copy link
Contributor

@ericpaulbishop please consider adding some trusted collaborators to the gargoyle project.

There is much to be done on the gargoyle development, and a number of people willing to contribute, but evaluation of pull-requests has been protracted in recent times. Adding one or more trusted collaborators, and an understanding that two or more should review pull-requests prior to merging, would speed the process without sacrificing quality unduly. Another approach might be to encourage collaborators to review and merge pull requests for experimental releases but retain sole control over official releases.

I for one have been happy to contribute significant development time to gargoyle - but having #403 in limbo for 4+ months saps my enthusiasm to contribute further.

@ericpaulbishop
Copy link
Owner

First, I apologize that it's taken so long to merge #403, but it's unusual how large that pull request is, and there's some show-stopper bugs (handling of device table without edit feature) as it was submitted. I try to merge small pull requests within a few days.

That said, I'll make you a deal: If both you and Lantis add a note to a pull request where both of you say you think it's ready to be merged as-is, unless I am aware of a show-stopper bug, I will merge it without further testing.

@nworbnhoj
Copy link
Contributor Author

@ericpaulbishop this is a welcome advance that hopefully works well in practice.

To be fair though, I sought feedback on the "handling of device table without edit feature" the day after the original pull request, and received no response. This "show-stopper bug" could have been resolved months ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants