-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable swipe for NavigationCard? #49
Comments
@hedgerwang has an upcoming way to do this. Hedger, can we be sure to add it to the docs? |
@ericvicenti : I'll do that once my latest diff lands. |
Any update? |
You can disable the gesture by doing this.
|
Any chance we could get panHandlers={null} to transfer to the NavigationCard when using a NavigationCardStack? |
@jarredwitt That sounds reasonable. Feel free to send a PR and tag me and/or Hedger |
@ericvicenti Will do. I also noticed that NavigationCard doesn't take the direction prop anymore. Was that intentional? |
However, once you start to let people "customize" this component, the prop "direction" may not make sense at all cause it not not necessarily match to what the animation style and gesture pan-handlers are doing. To be honest, I'm seriously considering removing NavigationCardStack and NavigationCard from the source code otherwise we'd end up with a component with countless of "customization" props that can't be defined stickily without contradicts to one or another. We've made such mistake with My advice of the replacement of
|
Could i disable swipe for NavigationCard?
The text was updated successfully, but these errors were encountered: