Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New job to manually make docker image of chosen commit #12116

Open
JkLondon opened this issue Sep 27, 2024 · 2 comments
Open

New job to manually make docker image of chosen commit #12116

JkLondon opened this issue Sep 27, 2024 · 2 comments
Assignees
Labels
devops imp2 Medium importance

Comments

@JkLondon
Copy link
Member

Rationale

Some platforms, like EthPandaOps tests, work exclusively with Docker images. When I need to fix something, I cannot test it directly until I create an image from my commit and publish it on DockerHub, or until it is merged into the main branch.

My proposal is to create a job that any developer (starting with the Erigon Team) can trigger. This job would:

Create a Docker image from a specific commit (entered manually). The image would be automatically deleted after n days to conserve storage space.
Enforce a usage limit per user to prevent overuse (for example, allowing 2-3 jobs per day, or whatever is deemed suitable).
I believe this should not be automated, as the developer should take full responsibility for the commit they choose to create an image from.

@JkLondon
Copy link
Member Author

@lystopad

@lystopad lystopad self-assigned this Sep 30, 2024
@yperbasis yperbasis added the imp2 Medium importance label Nov 1, 2024
@lystopad
Copy link
Member

@JkLondon , I have some progress here #12802
Let's test your request against some feature branch.

Note: my changes is not yet merged to the main branch. It require testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops imp2 Medium importance
Projects
None yet
Development

No branches or pull requests

3 participants