Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reintroduce MaxReorgDepthV3 logic when collating files. #12763

Open
sudeepdino008 opened this issue Nov 19, 2024 · 0 comments
Open

reintroduce MaxReorgDepthV3 logic when collating files. #12763

sudeepdino008 opened this issue Nov 19, 2024 · 0 comments
Assignees
Labels

Comments

@sudeepdino008
Copy link
Member

sudeepdino008 commented Nov 19, 2024

func (a *Aggregator) BuildFilesInBackground(txNum uint64) chan struct{} { -- builds snapshot files till passed txNum, however this doesn't account for leaving some data in db (since the latest data can have reorgs).

  • In erigon2, we had "hold 1 step in db" for snapshot files (txs/blocks/headers) and we moved to using MaxReorgDepthV3 for changesets.
  • caplin has safetyMargin in antiquary.go

we should also use something similar like MaxReorgDepthV3 for domain/history files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant