Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inMemoryExecution: don't create new StagedSync for each block #12821

Open
AskAlexSharov opened this issue Nov 21, 2024 · 0 comments
Open

inMemoryExecution: don't create new StagedSync for each block #12821

AskAlexSharov opened this issue Nov 21, 2024 · 0 comments
Labels

Comments

@AskAlexSharov
Copy link
Collaborator

in backend.go we have function with:
stateSync := stages2.NewInMemoryExecution
this function called on every block
means we re-create stagedsync.Sync object on each block - means loosing some caches (like D_LRU cache which binded to ExecuteBlockCfg.applyWorker object)

We do this way: because Notifications object seems passed from outside - but i'm not sure why/where do we need it.
Need somehow simplify it and create stagedsync.Sync object once at startup (same as notification object dedicated for inMemoryExecution).

@AskAlexSharov AskAlexSharov changed the title inMemoryExecution: pre-alloc sync object inMemoryExecution: don't create new StagedSync object for each block Nov 21, 2024
@AskAlexSharov AskAlexSharov changed the title inMemoryExecution: don't create new StagedSync object for each block inMemoryExecution: don't create new StagedSync for each block Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant