Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this library still being maintained? #166

Closed
swayson opened this issue Aug 14, 2020 · 8 comments
Closed

Is this library still being maintained? #166

swayson opened this issue Aug 14, 2020 · 8 comments

Comments

@swayson
Copy link
Contributor

swayson commented Aug 14, 2020

Hi there,

I am curious whether this library is still being maintained and taking PRs? @erikrose

It is a really good lib, and would be sad to see it go stale.

@erikrose
Copy link
Owner

I'm looking for helpers to review PRs, as I've been busy with concentrations elsewhere. Would you or the thumbs-uppers be interested? This is still the parsing library I reach for, and I still think it's important to have a good parsing lib around that decouples grammars from visitors. (The speed thing has become less of a focus now that non-pure-Python can be deployed easily and securely.)

@evanh
Copy link

evanh commented Aug 25, 2020

I'm interested in helping out with this. I've been working a lot with it recently and it's super useful.

@erikrose
Copy link
Owner

erikrose commented Aug 28, 2020

Thanks, @evanh! I'd be more than pleased to have your help. Do you want to start by looking over and commenting on some of the existing PRs, and then I'll do a meta-review, until our brains come into alignment? After a couple go well, I'll give you commit access, and we can go from there.

Just off the top of my head, these are my top priorities for Parsimonious:

  • Docs, which I have half-written on a branch
  • Fixing a bug I suspect exists where certain things passed to Visitors are iterables when they shouldn't be. This makes for a lot of surprising needs to implement visit_generic().
  • Reversing the precedence of And and Or, which is accidentally out of line with what every other PEG parser (and the original paper) do
  • Making visitors easier to write. We lost a lot of ergonomics with the transition to Python 3, since it no longer supports auto-unpacking into tuples in methods' formal param lists. Maybe do some inspect magic or something to match up with arg names (or kwargs, or something—design needed). Also, maybe don't bother passing constant terms (like "foo") to the visitor methods at all, for brevity; they're rarely useful. This would dovetail nicely with a revised param format, since the constant terms lack names. (Nah, what if somebody referenced the same other rule twice in a rule?)

Of course, since it's open-source, I'm quite open to others priorities, driven by the community. It's just fallen way down my priority list.

And of course, there's lot of infra cleanup to do. We should drop nose, which is obsolete. We should update the versions of Python we use in CI and drop support for Python 2. There are PRs open for both of those.

Thanks again!

@evanh
Copy link

evanh commented Sep 1, 2020

Sounds good, I'll start going through what's there and seeing where I can help.

@swayson
Copy link
Contributor Author

swayson commented Sep 2, 2020

Hi, I can help out but will need guidance from you guys on what to tackle.

@erikrose
Copy link
Owner

@swayson Thank you! You could review #135 or open a PR for the patch pointed to in #160. Or attack any of the bulleted priorities I mentioned above. If none of that excites you, we have a lot of open issues! If you list a few that appeal to you, I'd be happy to give an initial impression of whether they're worth pursuing.

@lonnen
Copy link
Collaborator

lonnen commented Mar 29, 2022

Thank you for the submissions, @swayson

closing this out for now

@alexchandel
Copy link

@evanh / @swayson are you still maintaining this, or is it unmaintained again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants