Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Think about building from 25.1 on #4

Closed
paulo-ferraz-oliveira opened this issue Sep 15, 2024 · 4 comments
Closed

Think about building from 25.1 on #4

paulo-ferraz-oliveira opened this issue Sep 15, 2024 · 4 comments
Labels
question Something to discuss, maybe (?)

Comments

@paulo-ferraz-oliveira
Copy link
Collaborator

This version already supported OpenSSL 3.0 fully, so this'd broaden the build range. It'd make for a faster transition in systems like asdf, etc. as well as CI that include the latest 3 Erlang/OTP versions.

@paulo-ferraz-oliveira paulo-ferraz-oliveira added the question Something to discuss, maybe (?) label Sep 16, 2024
@paulo-ferraz-oliveira
Copy link
Collaborator Author

@wojtekmach, is this a goal? Feel free to close, otherwise. My thinking would be that we could list Erlang/OTP versions from 25.1 and keep a moving window of support range as newer versions come out. Since we have the .txt it'd be easy to skip (from that list) to build the next release.

@wojtekmach
Copy link
Collaborator

Initially I was planning to only support OTP 27+ but you're right that it is more practical to support the last three major releases so starting from OTP 25.

I'll make sure the build script is generating docs chunks prior to OTP 27 too.

I'll also update the workflow_dispatch to only accept OTP 25+ so we don't accidentally build something we don't intend to support (e.g. erlang/otp sent us a webhook with OTP-24.3.4.X), we can of course lift that restriction up down the road.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

👍

25.1

If you intend on relying on OpenSSL 3.x, 25.1- can't be included in that range, apparently. I remember having issues trying to compile it, but maybe your process works (?)

My prior notes (from OTP release notes):

"

  • 25.1 states "Crypto is now considered to be usable with the OpenSSL 3.0 cryptolib for production code"
    • this means that if we're to have a openssl vs. otp matrix we can start linking to 3.0 from 25.1 on

"

Docs

I'll make sure the build script is generating docs chunks prior to OTP 27 too.

Perfect. On a macOS runner it's possible you'll have to make sha256sum available prior to 27.0-rc3; after that shasum should suffice.

I was thinking about exceptions and how easy it is to maintain them (not easy!) so it's possible to have a "don't build this OTP version on this macOS version" mechanism (e.g. a simple file with a comment (?)). We can deal with it in the future, because the build mechanism will surely have to be tweaked every now and then.

@wojtekmach
Copy link
Collaborator

wojtekmach commented Sep 23, 2024

I updated build scripts to build OTP 25+, there are some caveats with it which I've documented in the proposed README: https://github.com/erlef/otp_builds/blob/wm-initial/README.md#list-of-builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Something to discuss, maybe (?)
Projects
None yet
Development

No branches or pull requests

2 participants