Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we have an issue that informs us a new OpenSSL or wxWidgets version is out? #5

Open
paulo-ferraz-oliveira opened this issue Sep 15, 2024 · 6 comments
Labels
question Something to discuss, maybe (?)

Comments

@paulo-ferraz-oliveira
Copy link
Collaborator

So we could sync. CI and be "on top of latest"...

@paulo-ferraz-oliveira paulo-ferraz-oliveira added the question Something to discuss, maybe (?) label Sep 16, 2024
@paulo-ferraz-oliveira
Copy link
Collaborator Author

Or, more generally, how should we implement in such a way that we can rebuild older artifacts with newer OpenSSL versions?

@wojtekmach
Copy link
Collaborator

OTP team doesn't rebuild artifacts and so I wouldn't either. I don't think we care if there's a new OpenSSL or wxWidgets version, we don't need to be absolutely up to date in my opinion. What I'd do instead is see what openssl/wx version OTP builds for Windows are using so we're consistent.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

OTP team doesn't rebuild artifacts and so I wouldn't either

But they don't statically link OpenSSL for you either, unless you want, right? But I agree we can live without it and use the same versions as they do for Windows.

I'll leave this open, to think of a mechanism to obtain those versions and warn us. Sounds Ok?

@wojtekmach
Copy link
Collaborator

OTP builds for windows are statically linking openssl and wxwidgets.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

Ah, I wasn't thinking about Windows specifically, but you're right. If you feel we can accompany those without some sort of automated mechanism, feel free to close. I just wanted to understand if it's something we wanted.

@wojtekmach
Copy link
Collaborator

Yeah, I'd like to keep this open and add some automatic check that ensures we use the same versions as OTP. Can be a nightly job or whatever. It's a low priority but would be nice to have imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Something to discuss, maybe (?)
Projects
None yet
Development

No branches or pull requests

2 participants