-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search path for *.tar.gz releases #383
Comments
Hey, sorry I missed this ticket opening. I'll look this weekend. |
Sorry I didn't get back on this earlier. This is actually a common question and I'm not really sure how to address it. Since the tarball would be "deployed" in some fashion to the target machine to be used it doesn't make sense that it would need to be created in a form equivalent to how it would be required to be on the target. So the For example at Heroku we then upload that to s3 and instances will fetch a certain vsn from there to disk under the appropriate directory and name before running But the confusion has come up enough times that it may be best to change it to output to I'll look at doing that in the near future. |
@tsloughter #505 proposal could possibly be a solution to this issue |
closing since #505 has since been merged |
When we building a new release as tar archive we get something like
myrel-0.0.2.tar.gz
, i.e. in the<release-name>-<release-version>.tar.gz
form.Then we install it:
and get an error:
So the install script looks for the tar archive at
<path-to-releases-dir>/releases/<release-version>/<release-name>.tar.gz
.On the one hand, it is not a big problem to parse file name, extract release's name and version, then create new dir and copy the renamed file in there. On the other side, is there any reasonable cause for that? Why not simply look for
<release-name>-<release-version>.tar.gz
file in thereleases
or even some configurable directory?May be I've missed something, but it seems that the search path is hard-coded in
templates/install_upgrade_escript
.The text was updated successfully, but these errors were encountered: