Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump reviewdog version to 0.20.1 #131

Open
SMoraisAnsys opened this issue Aug 21, 2024 · 3 comments · May be fixed by #132
Open

Bump reviewdog version to 0.20.1 #131

SMoraisAnsys opened this issue Aug 21, 2024 · 3 comments · May be fixed by #132

Comments

@SMoraisAnsys
Copy link

Hi, I was wondering if this action could use a more recent version of reviewdog.

Currently, the version used is 0.17

const localReviewDog = await installReviewDog("0.17.0", core.getInput('reviewdog_url'));

while the most recent version is currently 0.20.1

One of the gain from changing the version would be to leverage -fail-level instead of -fail-on-error.
I don't know if you are open to the idea of adding back the level input which was removed previously (c4213d4). Since I couldn't find information on why it got removed, maybe that one of the reason for such limitation was the lack of feature in reviewdog and using the new version might help on this.

More information:

@jdkato
Copy link
Member

jdkato commented Aug 24, 2024

Yes, I'll update when I get a chance (PRs are also welcome).

You can also currently change the version of reviewdog by providing a value for reviewdog_url, although this won't help in cases where new features aren't yet supported in this action.

@SMoraisAnsys
Copy link
Author

Cool, I'll give it a try then ! Thanks for confirming that you are not against this changes :)

@anaxite anaxite linked a pull request Oct 1, 2024 that will close this issue
@anaxite
Copy link

anaxite commented Oct 1, 2024

I'm having a go at this request, and would appreciate feedback on the PR when possible.

Does it make sense to re-add the level input at the same time, or do it later? I'm leaving the PR as draft until I'm sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants