You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @DhanshreeA
I have followed the normal procedure of model incorporation. As soon as I got the message in the issue, I forked the repository to miquelduranfrigola/eos3mk2. I worked on that fork but then, when trying to do the PR, I was one commit behind ersilia-os/eos3mk2 for some reason.
I haven't thought to much about it, but, to me, this looks as if there are actions that happen after we write the message to the user containing the model id and the model incorporation steps.
In my opinion, the message should be the last thing appearing. No changes in the ersilia-os/eos3mk2 repository can happen after the identifier is revealed to the user.
Do you agree?
The text was updated successfully, but these errors were encountered:
Hi @DhanshreeA
I have followed the normal procedure of model incorporation. As soon as I got the message in the issue, I forked the repository to miquelduranfrigola/eos3mk2. I worked on that fork but then, when trying to do the PR, I was one commit behind ersilia-os/eos3mk2 for some reason.
I haven't thought to much about it, but, to me, this looks as if there are actions that happen after we write the message to the user containing the model id and the model incorporation steps.
In my opinion, the message should be the last thing appearing. No changes in the ersilia-os/eos3mk2 repository can happen after the identifier is revealed to the user.
Do you agree?
The text was updated successfully, but these errors were encountered: