Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One commit ahead after I fork? #1

Closed
miquelduranfrigola opened this issue Oct 23, 2024 · 2 comments
Closed

One commit ahead after I fork? #1

miquelduranfrigola opened this issue Oct 23, 2024 · 2 comments

Comments

@miquelduranfrigola
Copy link
Member

Hi @DhanshreeA
I have followed the normal procedure of model incorporation. As soon as I got the message in the issue, I forked the repository to miquelduranfrigola/eos3mk2. I worked on that fork but then, when trying to do the PR, I was one commit behind ersilia-os/eos3mk2 for some reason.
I haven't thought to much about it, but, to me, this looks as if there are actions that happen after we write the message to the user containing the model id and the model incorporation steps.
In my opinion, the message should be the last thing appearing. No changes in the ersilia-os/eos3mk2 repository can happen after the identifier is revealed to the user.
Do you agree?

@DhanshreeA
Copy link
Member

This is very strange and shouldn't be happening. Let me try to repro this with the eos-demo.

@miquelduranfrigola
Copy link
Member Author

We were not able to reproduce the error, so I close the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants