Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: Ersilia close when model serving is interrupted #1171

Closed
Malikbadmus opened this issue Jun 24, 2024 · 2 comments · Fixed by #1172
Closed

🐛 Bug: Ersilia close when model serving is interrupted #1171

Malikbadmus opened this issue Jun 24, 2024 · 2 comments · Fixed by #1172
Labels
bug Something isn't working

Comments

@Malikbadmus
Copy link
Contributor

Malikbadmus commented Jun 24, 2024

Describe the bug.

If the model serving process was interrupted when the service class has not been specified yet, you get this error when you use the ersilia close command.

Traceback (most recent call last):
  File "/root/miniconda3/bin/ersilia", line 8, in <module>
    sys.exit(cli())
  File "/root/miniconda3/lib/python3.10/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/root/miniconda3/lib/python3.10/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/root/miniconda3/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/root/miniconda3/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/root/miniconda3/lib/python3.10/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/ersilia/ersilia/cli/commands/__init__.py", line 22, in wrapper
    return func(*args, **kwargs)
  File "/ersilia/ersilia/cli/commands/close.py", line 16, in close
    service_class = session.current_service_class()
  File "/ersilia/ersilia/core/session.py", line 36, in current_service_class
    return data["service_class"]
KeyError: 'service_class'

Describe the steps to reproduce the behavior

  1. ersilia -v serve eos4tcc
  2. ctrl c
  3. ersilia close

Operating environment

Ubuntu 22.04.1

@Malikbadmus Malikbadmus added the bug Something isn't working label Jun 24, 2024
@Malikbadmus
Copy link
Contributor Author

Malikbadmus commented Jun 24, 2024

@DhanshreeA, this is a relatively minor issue.

It has been resolved with a tiny fix in this PR.

@DhanshreeA
Copy link
Contributor

Ah this is an interesting one. Thanks @Malikbadmus!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
2 participants