-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Bug: bentoml-ersilia
does not work with python 3.12
#1214
Comments
Related to #995 |
Also looking at the versioneer.py in bentoml-ersilia, I really don't understand what's happening in this line, specifically the import statement that is trying to import the class In any case, I propose adding an if condition to check the version of python process running this code and importing the correct class (ie |
Hey @miquelduranfrigola I've tried to fix it here: ersilia-os/bentoml-ersilia#1, please review and feel free to merge anytime. |
I've merged. Did you check that it works in a python 3.12 conda environment? |
@miquelduranfrigola - I've tested it with Python 3.12, it works! In a 3.12 conda env, I installed bentoml-ersilia followed by ersilia and tested running some basic ersilia commands (version, catalog, help) - no failures. I think it should be good to close, what do you think? |
Amazing. Thanks. Let's close it then. |
Describe the bug.
The package
bentoml-ersilia
cannot be installed in python 3.12. This is a critical bug and we need to fix it.I get the following error when trying
pip install git+https://github.com/ersilia-os/bentoml-ersilia.git
:conda create -n testenv python=3.12
conda activate testenv
pip install git+https://github.com/ersilia-os/bentoml-ersilia.git
The text was updated successfully, but these errors were encountered: