Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: pyairtable dependency missing from pyproject.toml #1242

Closed
kartikey-vyas opened this issue Aug 24, 2024 · 10 comments
Closed

🐛 Bug: pyairtable dependency missing from pyproject.toml #1242

kartikey-vyas opened this issue Aug 24, 2024 · 10 comments
Labels
bug Something isn't working

Comments

@kartikey-vyas
Copy link
Contributor

Describe the bug.

Noticed this while installing and running ersilia inside a github actions worker.

GHA worker was a standard ubuntu-latest. Dependencies installed via this set of commands:

cd ersilia
conda install -y python=3.10
conda init
python -m pip install -e .[test]

During the run we run into this error:

08:43:47 | DEBUG    | No need to use Conda!
/opt/hostedtoolcache/Python/3.10.14/x64/lib/python3.10/site-packages/fuzzywuzzy/fuzz.py:11: UserWarning: Using slow pure-python SequenceMatcher. Install python-Levenshtein to remove this warning
  warnings.warn('Using slow pure-python SequenceMatcher. Install python-Levenshtein to remove this warning')
🚨🚨🚨 Something went wrong with Ersilia 🚨🚨🚨

Error message:

No module named 'pyairtable'
If this error message is not helpful, open an issue at:
 - https://github.com/ersilia-os/ersilia
Or feel free to reach out to us at:
 - hello[at]ersilia.io

If you haven't, try to run your command in verbose mode (-v in the CLI)
 - You will find the console log file in: /home/runner/eos/current.log

Describe the steps to reproduce the behavior

No response

Operating environment

Ubuntu 22.04 (GitHub Actions runner)

@kartikey-vyas kartikey-vyas added the bug Something isn't working label Aug 24, 2024
@kartikey-vyas
Copy link
Contributor Author

working around this by adding pip install pyairtable as an extra command, so no urgency from our side :)

@DhanshreeA
Copy link
Contributor

Hey @kartikey-vyas, thank you for filing a bug report here! Could you please tell me which command(s) you ran that produced this error?

@DhanshreeA DhanshreeA self-assigned this Aug 28, 2024
@DhanshreeA DhanshreeA moved this from Queue to In Progress in Ersilia Model Hub Aug 28, 2024
@kartikey-vyas
Copy link
Contributor Author

Ah sorry, we just had the workflow calling

'ersilia serve eos2zmb'
'ersilia run eos2zmb -i input.csv -o output.csv'

@GemmaTuron
Copy link
Member

Hi @DhanshreeA and @kartikey-vyas

Has this issue been solved? Is pyairtable a needed dependency for Ersilia? I thought we had bypassed that, so why are we getting this error?

@DhanshreeA
Copy link
Contributor

This issue is presently creeping up because of the following issue: #1259

@GemmaTuron
Copy link
Member

Hi @DhanshreeA

Since #1259 has been closed, is this still an issue? Can you clarify if pyairtable is a dependency or not finally? I think it should not be right?

@GemmaTuron
Copy link
Member

Hello @DhanshreeA

Please update this issue

@DhanshreeA
Copy link
Contributor

Hi @GemmaTuron we have a final stretch goal of actually removing it entirely by adding a step in our workflows to update the information directly in S3 at the same time that it gets added to Airtable. Without that, there is still the possibility that we look for that information in S3 and don't find it and then fallback on Airtable.

@GemmaTuron
Copy link
Member

Hi @DhanshreeA

This has a deadline for 22nd Nov. Please if this is not completed change the deadline for the actual completion date

@DhanshreeA DhanshreeA moved this from In Progress to On Hold in Ersilia Model Hub Nov 29, 2024
@DhanshreeA DhanshreeA removed their assignment Nov 29, 2024
@DhanshreeA
Copy link
Contributor

This is now complete.

In the PR referenced above, I have moved all the Airtable code from main ersilia source to an airtableops script in the .github actions directory, importing Ersilia classes as necessary. Additionally, we sync data to the S3 JSON right after an update is made to Airtable, removing any dependency from using Airtable.

@github-project-automation github-project-automation bot moved this from On Hold to Done in Ersilia Model Hub Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants