Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ersilia pack dockerization #1258

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Ersilia pack dockerization #1258

merged 3 commits into from
Sep 23, 2024

Conversation

DhanshreeA
Copy link
Contributor

@DhanshreeA DhanshreeA commented Sep 19, 2024

This PR achieves a few things:

  1. Renaming sub-directories within the dockerfiles directory with more descriptive naming to indicate the evolution of Ersilia's Docker build approaches, namely, legacy-bentoml (v1), multistage-condapack (v2), and the latest approach - ersiliapack.
  2. Corresponding to this renaming, v1 and v2 have been replaced respectively with their descriptive names in ersilia-base-image-to-dockerhub.yml workflow, and place_a_dockerfile_in_current_eos_repo.py script.
  3. Template dockerfiles for ersilia pack dockerization have been introduced with relevant local build instructions.

@miquelduranfrigola
Copy link
Member

Any feedback you need from me, @DhanshreeA ?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…keriztion
@DhanshreeA DhanshreeA force-pushed the ersilia-pack-dockerization branch from 5ed3ee2 to b605bdd Compare September 23, 2024 01:02
@DhanshreeA
Copy link
Contributor Author

Any feedback you need from me, @DhanshreeA ?

Thanks @miquelduranfrigola , all good.

@DhanshreeA DhanshreeA merged commit 44a4896 into master Sep 23, 2024
21 checks passed
@DhanshreeA DhanshreeA deleted the ersilia-pack-dockerization branch September 23, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants