Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: Deciding to delete non-existing model #1400

Closed
Abellegese opened this issue Nov 25, 2024 · 8 comments
Closed

🐛 Bug: Deciding to delete non-existing model #1400

Abellegese opened this issue Nov 25, 2024 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@Abellegese
Copy link
Contributor

Describe the bug.

The delete cmd, when I tried to delete eos3b5e, the needes_delete considered that the image or model existed and considered it as it needs deletion, but the model was not there, its folder on both des and repo .

Describe the steps to reproduce the behavior

No response

Operating environment

Ubuntu LTS

@Abellegese Abellegese added the bug Something isn't working label Nov 25, 2024
@DhanshreeA
Copy link
Contributor

@Abellegese could you explain this a little bit more, especially this part:

considered it as it needs deletion, but the model was not there, its folder on both des and repo .

Do you mean to say that the model's folder in the dest and repo directories wasn't there?

@Abellegese
Copy link
Contributor Author

First time I ran the command and it was successfull, but when I delete same model again it says successfully deleted, and that need delete function was also True. But infact image, eos folder was mot there for the model if that makes sense.

@DhanshreeA
Copy link
Contributor

Thanks @Abellegese - that is somewhat making sense, however I need further clarity. Can you help me with the exact steps I could run to reproduce this? Thanks!

@DhanshreeA
Copy link
Contributor

@Abellegese is it somewhat related to this by any chance?

@Abellegese
Copy link
Contributor Author

Yeah a little bit related but mine was here maybe if you could be able to reproduce.

Fetch for instance eos3b5e
Delete it
Again try to delete it even its not there. Then its still consider it successfully deleted.

@DhanshreeA
Copy link
Contributor

DhanshreeA commented Nov 27, 2024

Hi @Abellegese I am still having trouble reproducing this, for example, this is what I see:

Screenshot 2024-11-27 at 17 44 19

I fetched eos3b5e, as you can see through the catalog output, and it has its corresponding folders in the dest and repository directories. I then deleted it, and it got successfully deleted, and then I deleted it again which raised an error, as expected.

@GemmaTuron
Copy link
Member

Hi @Abellegese
I am also unclear as to what you mean by this sentence: Again try to delete it even its not there. Then its still consider it successfully deleted.

Is it that you do the same procedure that @DhanshreeA is showing but then instead of saying No delete is necessary it shows a model deleted successfully message? Have you checked you are running the latest ersilia version and everything? And can you paste a screenshot of the error?

@GemmaTuron GemmaTuron moved this from On Hold to In Progress in Ersilia Model Hub Nov 28, 2024
@Abellegese
Copy link
Contributor Author

Abellegese commented Nov 28, 2024

This issue has been resolved when I tried latest ersilia version. I think I was kind of outdated.

@Abellegese Abellegese moved this from In Progress to Done in Ersilia Model Hub Nov 28, 2024
@Abellegese Abellegese closed this as completed by moving to Done in Ersilia Model Hub Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants