Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐅 Epic: Fix critical bugs in Ersilia #1536

Open
3 tasks
GemmaTuron opened this issue Feb 6, 2025 · 1 comment
Open
3 tasks

🐅 Epic: Fix critical bugs in Ersilia #1536

GemmaTuron opened this issue Feb 6, 2025 · 1 comment
Assignees
Labels
critical Critical issue that is a blocker and we need to solve immediately; use sparingly

Comments

@GemmaTuron
Copy link
Member

GemmaTuron commented Feb 6, 2025

Summary

There have been some bugs that cause the models not to work at the general Ersilia Level. This is hard to un-link from other issues but I will try to collect here bugs that need to be fixed:

It would be good to add these checks to the model test or the Ersilia CLI workflows to ensure they do not repeat. @Abellegese for the parsing to None outputs, we thought we could run a one single check in the Ersilia CLI with one model and one molecule we know fails in this model and ensure the None output is properly parsed. Thoughts?

Objective(s)

  • Ensure Ersilia is fully functional

Documentation

Ersilia's gitbook

@GemmaTuron GemmaTuron added the critical Critical issue that is a blocker and we need to solve immediately; use sparingly label Feb 6, 2025
@Abellegese
Copy link
Contributor

Abellegese commented Feb 7, 2025

Yes @GemmaTuron I agree with that. Whats even best is I think to create a small functions that enforces a correct parsing for all models. How do we do this? One way is to use the schema of the api to construct parsing rules the None as well as for the correct values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical Critical issue that is a blocker and we need to solve immediately; use sparingly
Projects
Status: On Hold
Development

No branches or pull requests

3 participants