Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defineProperty should NOT check for own property #211

Closed
WebReflection opened this issue Mar 29, 2014 · 0 comments
Closed

defineProperty should NOT check for own property #211

WebReflection opened this issue Mar 29, 2014 · 0 comments
Labels
Milestone

Comments

@WebReflection
Copy link
Member

all properties here are checked without following specs.

It might sound weird but only defineProperties checks for own property, the descriptor itself could have properties inherited.

It's a minor thing but for consistency sake of ES5 sham itself, you should change those checks and put in instead 'value' in obj or 'get' in obj and so on.

Take care

@ljharb ljharb added this to the v3.1.0 milestone May 6, 2014
@ljharb ljharb modified the milestones: v4.0.0, v4.1.0 Aug 14, 2014
@ljharb ljharb closed this as completed in 2bdad41 Dec 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants