Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider exposing composeReducers #31

Closed
Secretmapper opened this issue Jul 5, 2019 · 4 comments
Closed

Consider exposing composeReducers #31

Secretmapper opened this issue Jul 5, 2019 · 4 comments

Comments

@Secretmapper
Copy link
Contributor

Secretmapper commented Jul 5, 2019

Due to the nature of how immer-reducer works (working on arbitrary pieces of state), composing reducers is pretty much the direction in which the reducers would be created.

I think due to this, it might be a good idea to consider exposing composeReducers as a utility inside the library. It could even be put such that tree-shaking will remove it if unused. Happy to put in a PR if you think it's not out of scope

@esamattis
Copy link
Owner

Yes, PR welcome!

@Secretmapper
Copy link
Contributor Author

Any chance we can publish this in a new version :)

@esamattis
Copy link
Owner

Out with v0.7.6!

Sorry, it took a while. I was on vacation without npm credentials :)

@Secretmapper
Copy link
Contributor Author

No worries, Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants