Bounds check in vstore

[nlw0]

I noticed this line is commented on similar functions, with a "todo". Should this be the same case? In this about implementing some missing mechanism to allow @inbounds propagation to work?

SIMD.jl/src/SIMD.jl

Line 1488 in 1245797

@boundscheck 1 <= i <= length(arr) - (N-1) || throw(BoundsError())

[eschnett]

I have not carefully implemented bounds checking. SIMD should, of course, check array bounds by default, even if I expect most application code to opt out. A mechanism that ensures that @inbounds is working would be most appreciated.

[nlw0]

I hope I can try implementing this some day, but right now I see myself having to use my own patched package so I can comment this. Shouldn't this perhaps be made similar to the other functions while the mechanism isn't properly implemented? Or maybe we can make a separate function in order to keep this one with the check?

[eschnett]

@nlw0 I don't understand what you are suggesting.

[KristofferC]

Just make sure you use this inside a @inbounds block and the boundscheck goes away (actually probably not on master due to JuliaLang/julia#30411 but it should be fixed in #63)