fix(isracard): use the correct value for originalCurrency

[daniel-hauser]

Transactions in isracard has the wrong originalCurrency.
The correct mapping of the currencies should be:

• originalCurrency = currentPaymentCurrency
• chargedCurrency = currencyId

---

Attached is an example transaction that should have originalCurrency: "USD", chargedCurrency: "ILS" but before the code in this PR it's originalCurrency: "ILS" with no chargedCurrency

The isracard transaction object:

{
    ...
    "currencyId": "NIS",
    "currentPaymentCurrency": "USD",
    ...
    "fullSupplierNameOutbound": "UBER   TRIP",
    ...
    "dealSumOutbound": "66.66",
    "paymentSumOutbound": "248.24",
    ...
}

The israeli-bank-scrapers transaction object (diff before and after the change):

{
         ...
	"originalAmount": -66.66,
-	"originalCurrency": "ILS",
+	"originalCurrency": "USD",
+	"chargedCurrency": "ILS",
	"chargedAmount": -248.24,
	"description": "UBER   TRIP",
	...
}

[daniel-hauser]

@baruchiro / @eshaham / @esakal Can you please review? Thanks!

[baruchiro]

I know it sounds lazy, but I feel I need more focus to understand it (because I'm taking these reviews sometimes from my phone between things).

Can you edit the description with a "before and after" example, so the change will be thrown דוך to my eyes?

[baruchiro]

@galbarm @daniel-hauser Can you check if in your Dollar transactions there is a mistake?

I'm not paying with my Isracard on Dollars.

[baruchiro]

It's been approved, but I prefer someone who will reproduce this issue and approve your fix.

[esakal]

@daniel-hauser I"m not sure if this is ok or not

the amount is in $ but the currency is nis. this is the outcome of the test

is this what you expected?

Note that with this change for transactions whose original currency is ILS, the returned value for the original currency is now empty instead of ILS. this is intentionally?

[daniel-hauser]

@esakal Can you share the following values from your transaction (in the isracard website)?

{
    ...
    "currencyId": ,
    "currentPaymentCurrency": ,
    ...
    "fullSupplierNameOutbound": ,
    ...
    "dealSumOutbound": ,
    "paymentSumOutbound": ,
    ...
}

[github-actions]

🎉 This PR is included in version 5.1.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀