Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: 'node:sqlite' not marked as experimental #341

Open
scagood opened this issue Sep 20, 2024 · 1 comment
Open

Bug: 'node:sqlite' not marked as experimental #341

scagood opened this issue Sep 20, 2024 · 1 comment
Labels
bug rule:update An update to a current rule

Comments

@scagood
Copy link

scagood commented Sep 20, 2024

Environment

Node version: 22.5.0
ESLint version: 9.11.0
eslint-plugin-n version: 17.10.3

What rule do you want to report?

no-unsupported-features/node-builtins

Link to Minimal Reproducible Example

https://eslint-online-playground.netlify.app/#eNpVUMtuwyAQ/JUVF19ip4rUi6v2FKkf0GPJgZh1QosXyiNKZPnfC4ZECge0DDOzszsz74YtXsVkNXY/nvVMTda4ADNMIgxn9J/aHGGB0ZkJGjISeyvCuXnj9GDuRRBH4fHrRsMz1f9pFTCT2Yah14pCNxga1empGVVNYbRWx5OilrKOE15XjsRRRB3gmxPAnC+AQvR9ykCwbAroosYMlRekJFsybSQfbTZC2Y4oQnToEy6xPUalQ3Jp+uJdVeiccU31zGeGCzqvDPXQfLzDbte9di/Noy3AoVYFyfehDG7F8CtOeb+G0tBrMs7CzSJnfaomI1NmzlYdZxIve7RIEmlQ6DOnDsPrDotMi4A+1bXt/fOxvmfWmonTwpZ/qPui3w==

What did you expect to happen?

node:sqlite is not being marked as experimental, despite it being configured as such:
https://github.com/eslint-community/eslint-plugin-n/blob/master/lib/unsupported-features/node-builtins-modules/sqlite.js#L14

I think this is because the import is experimental, but the references (which we iterate over) are not.

@scagood scagood added bug rule:update An update to a current rule labels Sep 20, 2024
@scagood
Copy link
Author

scagood commented Sep 20, 2024

On a second little note, I think we should make DatabaseSync an exception in n/no-sync, as its always synchronous and always will be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug rule:update An update to a current rule
Projects
None yet
Development

No branches or pull requests

1 participant