Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: cross test merged rules (partial) #520

Merged
merged 1 commit into from
Aug 29, 2024
Merged

test: cross test merged rules (partial) #520

merged 1 commit into from
Aug 29, 2024

Conversation

antfu
Copy link
Member

@antfu antfu commented Aug 29, 2024

Part of #482 Stage 2

This PR runs both JS/TS tests against each merged rule, to ensure the merged rules works the same with both JS/TS parsers.

There are some rule failing, this PR marks them as // TODO: Stage 2: Test merged rule (you can find them with a global search).

After those rules are migrated, we can then consider Stage 2 as finished.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.73%. Comparing base (7c7301e) to head (8cf58f5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #520   +/-   ##
=======================================
  Coverage   99.73%   99.73%           
=======================================
  Files         120      120           
  Lines       19521    19521           
  Branches     4740     4742    +2     
=======================================
  Hits        19470    19470           
  Misses         51       51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antfu antfu merged commit 97448b9 into main Aug 29, 2024
13 checks passed
@antfu antfu deleted the refactor/test-cross branch August 29, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant