Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alignment hostname #61

Merged
merged 1 commit into from
Jun 11, 2024
Merged

fix: alignment hostname #61

merged 1 commit into from
Jun 11, 2024

Conversation

ycs77
Copy link
Contributor

@ycs77 ycs77 commented Jun 11, 2024

If the hostname is localhost / 127.0.0.1, the log print host name and opened hostname are different:

螢幕擷取畫面 2024-06-11 144025

So this PR alignment the print hostname with the opened hostname.

The opened hostname source:

config-inspector/src/cli.ts

Lines 102 to 106 in e7b6552

server.listen(port, host, async () => {
if (options.open)
await open(`http://${host === '127.0.0.1' ? 'localhost' : host}:${port}`)
})
})

@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Jun 11, 2024
Copy link

linux-foundation-easycla bot commented Jun 11, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ycs77 / name: Lucas Yang (ac3cf0a)

@ycs77 ycs77 closed this Jun 11, 2024
@ycs77 ycs77 reopened this Jun 11, 2024
@antfu antfu merged commit 1546667 into eslint:main Jun 11, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Jun 11, 2024
@ycs77 ycs77 deleted the fix/print-localhost branch June 11, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants