Fix second variable reported location

Author: nzakas

src/rules/no-invalid-properties.js

@@ -42,8 +42,14 @@ function replaceWithOffsets(text, varName, replaceValue) {
 
 	while ((match = regex.exec(text)) !== null) {
 		result += text.slice(lastIndex, match.index);
+
+		/*
+		 * We need the offset of the replacement after other replacements have
+		 * been made, so we push the current length of the result before appending
+		 * the replacement value.
+		 */
+		offsets.push(result.length);
 		result += replaceValue;
-		offsets.push(match.index);
 		lastIndex = match.index + match[0].length;
 	}
 

tests/rules/no-invalid-properties.test.js

@@ -386,5 +386,22 @@ ruleTester.run("no-invalid-properties", rule, {
 				},
 			],
 		},
+		{
+			code: "a { --width: 1px; border-top: var(--width) solid var(--width); }",
+			errors: [
+				{
+					messageId: "invalidPropertyValue",
+					data: {
+						property: "border-top",
+						value: "1px",
+						expected: "<line-width> || <line-style> || <color>",
+					},
+					line: 1,
+					column: 50,
+					endLine: 1,
+					endColumn: 62,
+				},
+			],
+		},
 	],
 });