-
-
Notifications
You must be signed in to change notification settings - Fork 32
feat!: Remove Tailwind syntax in favor of external tailwind-csstree #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @nzakas!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.
To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page. Read more about contributing to ESLint here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the built-in Tailwind CSS syntax support and updates the plugin to rely on the external tailwind-csstree package.
- Eliminates internal
/syntaxsource, build configs, and TS configs - Updates tests and docs to import
tailwind-csstreeinstead of the removedtailwindSyntax - Cleans up package exports, build scripts, and dependencies
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.syntax.json | Removed TS config for internal syntax output |
| tests/rules/no-invalid-at-rules.test.js | Switched customSyntax imports from internal to tailwind3 |
| src/syntax/tailwind-syntax.js | Deleted internal Tailwind syntax definitions |
| src/syntax/index.js | Removed re-export of tailwindSyntax |
| rollup.config.js | Dropped the syntax bundle configuration |
| package.json | Removed syntax entrypoint, adjusted build scripts, added dependency |
| jsr.json | Removed ./syntax export |
| README.md | Updated docs to install and import from tailwind-csstree |
Comments suppressed due to low confidence (2)
README.md:233
- The README example imports
tailwind4but tests and the package usetailwind3. Update the example to match the actual export (e.g.tailwind3) or clarify version support.
import { tailwind4 } from "tailwind-csstree";
package.json:106
- [nitpick] Consider moving
tailwind-csstreefrom devDependencies to peerDependencies so that consumers explicitly install a compatible version rather than relying on your dev setup.
"tailwind-csstree": "^0.1.0",
fasttime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Leaving open for a second review.
Prerequisites checklist
What is the purpose of this pull request?
Updated Tailwind support recommend using the
tailwind-csstreepackage that I wrote on my own time. It covers Tailwind 3 and 4 and is much more robust than what we had in this plugin.What changes did you make? (Give an overview)
tailwind-csstree/syntaxentrypoint frompackage.jsonandjsr.json/syntax/syntaxRelated Issues
Is there anything you'd like reviewers to focus on?