fix: enforce unique items in the options of prefer-logical-properties
#176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumirlumir
changed the title
prefer-logical-propertiesprefer-logical-properties
nzakas
deleted the
fix-enforce-unique-items-in-the-options-of-prefer-logical-properties
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Hello,
In this PR, I’ve added
uniqueItems: trueto the JSON schema ofprefer-logical-properties.Currently, users can pass duplicate properties like this:
However, considering the purpose of the option, I think it makes more sense to allow only unique items.
What changes did you make? (Give an overview)
I’ve added
uniqueItems: trueto the JSON schema ofprefer-logical-properties.Related Issues
Nothing.
Is there anything you'd like reviewers to focus on?
Nothing.