feat: add suggestion to no-important rule to remove !important flag #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumirlumir
added
the
accepted
nzakas
reviewed
Jul 29, 2025
Member
nzakas
left a comment
nzakas
left a comment
There was a problem hiding this comment.
This looks like a good start. Just a couple of bits to clean up.
Contributor
There was a problem hiding this comment.
Right now, if somehow the CSS comment before the !important flag contains the !important, then the rule reports the one inside the comment.
a { color: red /* !important flag 1 */ !important; }
/* after fix the output will be */
a { color: red /* flag 1 */ !important; }
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
This pull request enhances the
no-importantrule by providing a suggestion to remove the!importantflag from CSS declarations.What changes did you make? (Give an overview)
no-importantrule that removes the!importantflag from CSS declarations.!importantflag removed.Related Issues
Fixes #204
Is there anything you'd like reviewers to focus on?